CHANGE: @W-17353518@ Upgrading dependencies where possible #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(violationsFromTsFile).toHaveLength(6); | ||
| expect(new Set(violationsFromTsFile.map(v => v.ruleName))).toEqual(new Set([ | ||
| '@typescript-eslint/ban-types', | ||
| '@typescript-eslint/no-wrapper-object-types', |
Contributor
Author
There was a problem hiding this comment.
@typescript-eslint/ban-types was deprecated in favor of 3 other rules - one of which is @typescript-eslint/no-wrapper-object-types
stephen-carter-at-sf
force-pushed
the
sc/W-17293079
branch
from
d83137b to
031069b
Compare
| @@ -0,0 +1 @@ | |||
| registry=https://registry.npmjs.org No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
Forcing npmjs registry so that my user's .npmrc file for core development doesn't keep getting in the way.
stephen-carter-at-sf
force-pushed
the
sc/W-17293079
branch
3 times, most recently
from
44ba518 to
6e48305
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-17293079
branch
from
6e48305 to
1a9be01
Compare
jfeingold35
reviewed
Dec 3, 2024
| "name": "@salesforce/code-analyzer-core", | ||
| "description": "Core Package for the Salesforce Code Analyzer", | ||
| "version": "0.17.0", | ||
| "version": "0.18.0-SNAPSHOT", |
Contributor
There was a problem hiding this comment.
Q: Should the dependency on the Engine API be updated to 0.15.0-SNAPSHOT too, or should I do that when I do the SARIF stuff?
jfeingold35
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.