NEW @W-17159591@ SARIF output now passes official validation #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
force-pushed
the
d/W-17159591-b
branch
from
703e4c6 to
3b0e304
Compare
jfeingold35
commented
Dec 3, 2024
| } | ||
| } | ||
| } else { | ||
| return { |
Contributor
Author
There was a problem hiding this comment.
The validator didn't like having an empty region object, so I'm just using an empty artifactLocation object outright when there's no code location.
Technically I suppose it's possible we could see a case where there's a code location with no start line or anything else, and the output of that would be invalid SARIF. I can account for that scenario if consensus is that it's worth the trouble.
stephen-carter-at-sf
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.