CHANGE: @W-19582414@ Export ViolationCounts #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
commented
Sep 8, 2025
|
|
||
| export type { | ||
| ViolationCounts | ||
| } from "./output-formats/results/json-run-results-format" |
Contributor
Author
There was a problem hiding this comment.
I first hoisted this into output-format.ts, but that felt strange since I wasn't using it in there, but I could do that to make this look cleaner if it's preferable
Contributor
There was a problem hiding this comment.
Instead of exporting this from the top level... I'd prefer if we instead switched to use "exports" instead of "main" sort of like we do with our engine-api module. See: https://github.com/forcedotcom/code-analyzer-core/blob/dev/packages/code-analyzer-engine-api/package.json#L13-L16
Then you can put an index.ts inside of the output-formats folder... so that the import over on the MCP tool provider side looks something like
import { ViolationCounts } from "@salesforce/code-analyzer-core/output-formats"
stephen-carter-at-sf
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: