CHANGE: @W-19586349@ Fix husky publishing issue #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
commented
Sep 8, 2025
| "showcoverage-typescript": "open ./coverage/lcov-report/index.html", | ||
| "showcoverage": "npm run showcoverage-java && npm run showcoverage-typescript", | ||
| "prepare": "husky" | ||
| "prepare": "husky || true" |
Contributor
Author
There was a problem hiding this comment.
I also considered adding a --ignore-scripts flag to the npm install step of publish-package-to-npm.yml, but that would skip any future lifecycle scripts too, which may be tricky to troubleshoot.
stephen-carter-at-sf
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
huskyis causing publishing failures. This is because it is a top level dependency, but each monorepo doesn't have (or need) it. The fix I went with is to ensure that a missing husky dependency doesn't prevent publishing, as recommended by their documentation. This looked good locally too.