FIX @W-19772057@ Fixed oversight in selector code #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
reviewed
Oct 6, 2025
| export function toSelector(selectorString: string): Selector { | ||
| // We parse the selector back-to-front, so that the front-most selectors end up at the bottom of the tree we create | ||
| // and therefore get resolved first. | ||
| console.log(`selector is ${selectorString}`); |
Contributor
There was a problem hiding this comment.
Can the console statements be removed?
randi274
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a slight oversight in my initial selector code. Previously, it would try to split
(2,3):pmdinto(2and3):pmdinstead of(2,3)andpmd. This has been addressed.