NEW @W-19397402@ Added hidden root_working_folder config property #370
Conversation
jfeingold35
force-pushed
the
d/W-19397402-2
branch
from
2e88d7c to
ac9ce40
Compare
| CONFIG_ROOT: 'config_root', | ||
| LOG_FOLDER: 'log_folder', | ||
| LOG_LEVEL: 'log_level', | ||
| WORKING_FOLDERS_ROOT: 'working_folders_root', // Hidden |
There was a problem hiding this comment.
hmm - part of me wants to have this say "root_working_folder" instead... because it parallels "log_folder" in a way. I'm even on the fence wondering if we instead call this "working_folder" and remove root as it can be implied - sort of like how log_folder is a bit implied. But since it is hidden - we can do naming if we ever decide to make this exposed.
| private relPathsToKeep: Set<string> = new Set(); | ||
|
|
||
| constructor(fileSystem: FileSystem = new RealFileSystem(), rootFolderPrefix: string = path.join(os.tmpdir(), 'code-analyzer-')) { | ||
| constructor(fileSystem: FileSystem = new RealFileSystem(), rootFolderPath: string = os.tmpdir()) { |
There was a problem hiding this comment.
Notice how you have this say rootFolderPath - which is another indication that we are dealing with a rootWorkingFolder instead of a workingFoldersRoot. Just an observation.
| constructor(fileSystem: FileSystem = new RealFileSystem(), rootFolderPath: string = os.tmpdir()) { | ||
| this.fileSystem = fileSystem; | ||
| this.rootFolderPrefix = rootFolderPrefix; | ||
| this.rootFolderPrefix = path.join(rootFolderPath, 'code-analyzer-'); |
There was a problem hiding this comment.
I see you removed option to supply the prefix. I think this is fine since I was on the fence of whether to do so before. Until we reuse the TempFolder for other purposes - this seems fine.
jfeingold35
changed the title
No description provided.