Skip to content

Commit 676a2b8

Browse files
authored
CHANGE @W-17100347@ Removed mentions of JUnit from CLI (#1675)
1 parent a132990 commit 676a2b8

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

messages/results-writer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# error.unrecognized-file-format
22

3-
The output file %s has an unsupported extension. Valid extensions include: .csv; .html/.htm; .json; .junit/.junit.xml; .sarif/.sarif.json; .xml.
3+
The output file %s has an unsupported extension. Valid extensions include: .csv; .html/.htm; .json; .sarif/.sarif.json; .xml.

messages/run-command.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ If you don't specify this flag, the command outputs the results in the terminal.
133133
- .csv
134134
- .html or .htm
135135
- .json
136-
- .junit or .junit.xml
137136
- .sarif or .sarif.json
138137
- .xml
139138

src/lib/writers/ResultsWriter.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ export class ResultsFileWriter implements ResultsWriter {
3939
// Check for `.json` AFTER checking for `.sarif.json`!
4040
} else if (ext === '.json') {
4141
this.format = OutputFormat.JSON;
42-
} else if (ext === '.junit' || file.toLowerCase().endsWith('.junit.xml')) {
43-
throw new Error('TODO: Support JUNIT-type output');
44-
// Check for `.xml` AFTER checking for `.junit.xml`!
4542
} else if (ext === '.xml') {
4643
this.format = OutputFormat.XML;
4744
} else {

test/lib/writers/ResultsWriter.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ describe('ResultsWriter implementations', () => {
2323
{ext: '.html', expectedOutput: `Results formatted as ${OutputFormat.HTML}`},
2424
{ext: '.htm', expectedOutput: `Results formatted as ${OutputFormat.HTML}`},
2525
{ext: '.json', expectedOutput: `Results formatted as ${OutputFormat.JSON}`},
26-
//{ext: '.junit', expectedOutput: `Results formatted as ${OutputFormat.JUNIT}`},
27-
//{ext: '.junit.xml', expectedOutput: `Results formatted as ${OutputFormat.JUNIT}`},
2826
//{ext: '.sarif', expectedOutput: `Results formatted as ${OutputFormat.SARIF}`},
2927
//{ext: '.sarif.json', expectedOutput: `Results formatted as ${OutputFormat.SARIF}`},
3028
{ext: '.xml', expectedOutput: `Results formatted as ${OutputFormat.XML}`}
@@ -48,8 +46,6 @@ describe('ResultsWriter implementations', () => {
4846
* in the case array for the valid format tests.
4947
*/
5048
it.each([
51-
{ext: '.junit'},
52-
{ext: '.junit.xml'},
5349
{ext: '.sarif'},
5450
{ext: '.sarif.json'}
5551
])('Throws TODO error for not-yet-supported format: *$ext', ({ext}) => {

0 commit comments

Comments
 (0)