chore: Mark slow tests as skipped #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The four test cases * DataCloudConnectionFunctionalTest.testNetworkTimeoutDefault * DataCloudConnectionFunctionalTest.testNetworkTimeoutIsPerGrpcCall * DataCloudConnectionFunctionalTest.testNetworkTimeoutPropagatesToServer * QueryTimeoutTest.testNetworkTimeoutDoesntInterfereWithLocalEnforcement run for roughly 2 minutes, each. This is unbearable for an efficient development process. Disable the test cases until we prioritize fixing the runtimes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
============================================
- Coverage 83.38% 83.33% -0.06%
+ Complexity 1282 1280 -2
============================================
Files 104 104
Lines 3865 3865
Branches 328 328
============================================
- Hits 3223 3221 -2
- Misses 487 488 +1
- Partials 155 156 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The four test cases
run for roughly 2 minutes, each.
This is unbearable for an efficient development process. Disable the test cases until we prioritize fixing the runtimes.