Skip to content

Avatical Removal Part1: remove Avatica dependency from metadata conversion flow #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carsheng wants to merge 18 commits into
base: main
Choose a base branch
from

test: add more accessor tests

c28d02a
Select commit
Loading
Failed to load commit list.
Open

Avatical Removal Part1: remove Avatica dependency from metadata conversion flow #136

test: add more accessor tests
c28d02a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 9, 2026 in 0s

82.43% (-1.04%) compared to b8c5eb9

View this Pull Request on Codecov

82.43% (-1.04%) compared to b8c5eb9

Details

Codecov Report

❌ Patch coverage is 69.88235% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.43%. Comparing base (b8c5eb9) to head (c28d02a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...datacloud/jdbc/core/resultset/SimpleResultSet.java 63.46% 20 Missing and 18 partials ⚠️
...e/datacloud/jdbc/core/SimpleMetadataResultSet.java 57.83% 20 Missing and 15 partials ⚠️
...core/resultset/ResultSetWithPositionalGetters.java 35.29% 22 Missing ⚠️
...force/datacloud/jdbc/core/metadata/ColumnType.java 24.00% 18 Missing and 1 partial ⚠️
...ud/jdbc/core/metadata/SimpleResultSetMetaData.java 81.57% 3 Missing and 4 partials ⚠️
...loud/jdbc/core/resultset/ForwardOnlyResultSet.java 75.00% 3 Missing and 1 partial ⚠️
...esforce/datacloud/jdbc/core/QueryMetadataUtil.java 90.47% 2 Missing ⚠️
...tacloud/jdbc/core/resultset/ReadOnlyResultSet.java 98.93% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #136      +/-   ##
============================================
- Coverage     83.47%   82.43%   -1.04%     
- Complexity     1271     1509     +238     
============================================
  Files           104      113       +9     
  Lines          3765     4214     +449     
  Branches        375      420      +45     
============================================
+ Hits           3143     3474     +331     
- Misses          462      535      +73     
- Partials        160      205      +45
Components Coverage Δ
JDBC Core 83.47% <69.88%> (-2.09%) ⬇️
JDBC Main 40.69% <ø> (ø)
JDBC HTTP 91.09% <ø> (ø)
JDBC Utilities 66.07% <ø> (+5.10%) ⬆️
Spark Datasource ∅ <ø> (∅)
Files with missing lines Coverage Δ
.../datacloud/jdbc/core/resultset/ColumnAccessor.java 100.00% <100.00%> (ø)
...e/datacloud/jdbc/util/ArrowToColumnTypeMapper.java 62.26% <ø> (ø)
...com/salesforce/datacloud/jdbc/util/ArrowUtils.java 84.12% <ø> (ø)
...tacloud/jdbc/core/resultset/ReadOnlyResultSet.java 98.93% <98.93%> (ø)
...esforce/datacloud/jdbc/core/QueryMetadataUtil.java 91.48% <90.47%> (-0.15%) ⬇️
...loud/jdbc/core/resultset/ForwardOnlyResultSet.java 75.00% <75.00%> (ø)
...ud/jdbc/core/metadata/SimpleResultSetMetaData.java 81.57% <81.57%> (ø)
...force/datacloud/jdbc/core/metadata/ColumnType.java 68.96% <24.00%> (ø)
...core/resultset/ResultSetWithPositionalGetters.java 35.29% <35.29%> (ø)
...e/datacloud/jdbc/core/SimpleMetadataResultSet.java 57.83% <57.83%> (ø)
... and 1 more

... and 21 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov