feat: Improve authentication error logging and retry handling #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (73.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
============================================
- Coverage 83.47% 83.23% -0.25%
- Complexity 1271 1289 +18
============================================
Files 104 105 +1
Lines 3765 3859 +94
Branches 375 396 +21
============================================
+ Hits 3143 3212 +69
- Misses 462 475 +13
- Partials 160 172 +12
🚀 New features to boost your workflow:
|
Enhanced error logging and retry logic for authentication failures to
provide better visibility into transient server errors and improve
resilience against flaky authentication endpoints.
Changes:
- Enhanced AuthorizationException.getMessage() to include HTTP status
code and error description in a structured format
- Added AuthorizationException.isRetriable() method to identify
transient errors that should be retried:
* All 5xx server errors (500, 502, 503, 504, etc.)
* 400 errors with retry hints ("retry your request", "unknown_error")
* 429 rate limit errors
- Updated FormCommand to handle 5xx errors as AuthorizationException
instead of IOException for consistent retry handling
- Modified retry policy in DataCloudTokenProvider to retry retriable
AuthorizationExceptions while failing fast on permanent auth errors
- Added comprehensive retry logging:
* WARN logs on each retry attempt with attempt number and error details
* ERROR logs when all retries are exhausted
- Improved error logging in getWithRetry() to extract and log full
error details including HTTP codes and error descriptions
This improves debugging of authentication issues and makes the driver
more resilient to transient server-side failures commonly seen in
test environments.
KaviarasuSakthivadivel
force-pushed
the
improve-auth-error-logging-and-retry
branch
from
fa56d30 to
2866da5
Compare
mkaufmann
approved these changes
Dec 11, 2025
Comment on lines
+67
to
+76
| // Retry on 400 errors that indicate transient issues | ||
| if (httpCode == 400) { | ||
| String description = errorDescription != null ? errorDescription.toLowerCase() : ""; | ||
| // Check for retry hints in the error description | ||
| return description.contains("retry") | ||
| || description.contains("unknown_error") | ||
| || description.contains("temporary") | ||
| || description.contains("rate limit") | ||
| || description.contains("throttle"); | ||
| } |
Member
There was a problem hiding this comment.
Did you see this really occurring? Generally 400 looks to be something that the server consider a client error and thus I wouldn't retry on it https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced error logging and retry logic for authentication failures to provide better visibility into transient server errors and improve resilience against flaky authentication endpoints.
Changes:
This improves debugging of authentication issues and makes the driver more resilient to transient server-side failures commonly seen in test environments.