fix: Platform-aware shell handling and AgentforceSDK upgrade#150
Merged
haifeng-li-at-salesforce merged 2 commits intoforcedotcom:mainfrom Jan 29, 2026
Merged
Conversation
…st tests accordingly
… avatarConfiguration type to Image
| const childProcess = spawn(command, args, { | ||
| env, | ||
| shell: true, | ||
| shell: isWindows, |
Contributor
Author
There was a problem hiding this comment.
For iOS, setting shell: true causes a single parameter that contains spaces to be interpreted as two separate parameters.
| pod 'AgentforceSDK', '14.7.6' | ||
| pod 'Messaging-InApp-Core', '1.9.3-Experimental' | ||
| pod 'AgentforceSDK', '14.13.1' | ||
| pod 'Messaging-InApp-Core', '1.10.2' |
Contributor
Author
There was a problem hiding this comment.
Resolve the build and launch issue
ben-zhang-at-salesforce
approved these changes
Jan 29, 2026
Contributor
ben-zhang-at-salesforce
left a comment
ben-zhang-at-salesforce
left a comment
There was a problem hiding this comment.
jointed coded it and manually verified that it fixed the build and deploy issue for ios app generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
shell: trueon Windows,shell: falseon macOS/Linux) to properly handle arguments with spaces