RELEASE @W-18117811@ Conducting v1.6.0 release

.github/workflows/build-scanner-tarball.yml

@@ -28,8 +28,13 @@ jobs:
           git clone -b ${{ inputs.target-branch }} https://github.com/forcedotcom/sfdx-scanner.git sfdx-scanner
           cd sfdx-scanner
           # Install and build dependencies.
-          yarn
-          yarn build
+          if [[ "${{ inputs.target-branch}}" == "dev-4" ]]; then
+            yarn
+            yarn build
+          else
+            npm install
+            npm run build
+          fi
           # Create the tarball.
           npm pack
       # Upload the tarball as an artifact so it's usable elsewhere.

.github/workflows/validate-pr.yml

@@ -24,15 +24,21 @@ jobs:
           PR_INTO_DEV_OR_RELEASE_REGEX="^(FIX|CHANGE|NEW)([[:space:]]*\([^)]+\))?[[:space:]]*:?[[:space:]]*@W-[[:digit:]]{8,9}@.+"
 
           # Validate PR title based on base_ref and head_ref
-          if [[ "$base_ref" == "dev" && "${{ startsWith(github.head_ref, 'm2d/') }}" == "true" && ! "$title_upper" =~ $MAIN2DEV_REGEX ]]; then
-            echo "::error::Invalid PR title: '$title'. Please follow the format: Main2Dev (__) @W-XXXXXXXX@ Merging.*\d+\.\d+\.\d+"
-            exit 1
-          elif [[ "$base_ref" == "main" && ! "$title_upper" =~ $RELEASE2MAIN_REGEX ]]; then
-            echo "::error::Invalid PR title: '$title'. Please follow the format: RELEASE @W-XXXXXXXX@ Summary"
-            exit 1
-          elif [[ ("$base_ref" == "dev" || "${{ startsWith(github.base_ref, 'release-') }}" == "true") && ! "$title_upper" =~ $PR_INTO_DEV_OR_RELEASE_REGEX ]]; then
-            echo "::error::Invalid PR title: '$title'. Please follow the format: FIX|CHANGE|NEW (__) @W-XXXXXXXX@ Summary"
-            exit 1
+          if [[ "$base_ref" == "dev" && "${{ startsWith(github.head_ref, 'm2d/') }}" == "true" ]]; then
+            if [[ ! "$title_upper" =~ $MAIN2DEV_REGEX ]]; then
+              echo "::error::Invalid PR title: '$title'. Please follow the format: Main2Dev (__) @W-XXXXXXXX@ Merging.*\d+\.\d+\.\d+"
+              exit 1
+            fi
+          elif [[ "$base_ref" == "main" ]]; then
+            if [[ ! "$title_upper" =~ $RELEASE2MAIN_REGEX ]]; then
+              echo "::error::Invalid PR title: '$title'. Please follow the format: RELEASE @W-XXXXXXXX@ Summary"
+              exit 1
+            fi
+          elif [[ "$base_ref" == "dev" || "${{ startsWith(github.base_ref, 'release-') }}" == "true" ]]; then
+            if [[ ! "$title_upper" =~ $PR_INTO_DEV_OR_RELEASE_REGEX ]]; then
+              echo "::error::Invalid PR title: '$title'. Please follow the format: FIX|CHANGE|NEW (__) @W-XXXXXXXX@ Summary"
+              exit 1
+            fi
           else
             echo "PR title '$title' automatically accepted for $base_ref branch."
           fi

SHA256.md

@@ -15,7 +15,7 @@ make sure that their SHA values match the values in the list below.
 shasum -a 256 <location_of_the_downloaded_file>
 
 3. Confirm that the SHA in your output matches the value in this list of SHAs.
-   b148099eb0950f4001441d6e527f5e0333ac48abf865dbc2b2089551071504df  ./extensions/sfdx-code-analyzer-vscode-1.4.0.vsix
+   8dbf73cb26d6dbc695b5d0fe0f901ab7cbf1fb834640713dfb717209c224474d  ./extensions/sfdx-code-analyzer-vscode-1.5.1.vsix
 4. Change the filename extension for the file that you downloaded from .zip to
    .vsix.
 

package.json

@@ -13,7 +13,7 @@
         "color": "#ECECEC",
         "theme": "light"
     },
-    "version": "1.5.1",
+    "version": "1.6.0",
     "publisher": "salesforce",
     "license": "BSD-3-Clause",
     "engines": {
@@ -35,15 +35,15 @@
         "@types/jest": "^29.5.14",
         "@types/semver": "^7.5.8",
         "@types/tmp": "^0.2.6",
-        "cross-spawn": "^7.0.6",
+        "diff": "^5.2.0",
         "glob": "^11.0.1",
         "semver": "^7.7.1",
         "tmp": "^0.2.3"
     },
     "devDependencies": {
         "@eslint/js": "^9.21.0",
+        "@types/diff": "^5.2.0",
         "@types/chai": "^4.3.5",
-        "@types/cross-spawn": "^6.0.2",
         "@types/mocha": "^10.0.1",
         "@types/node": "^22.13.6",
         "@types/sinon": "^10.0.15",
@@ -90,7 +90,10 @@
         "showcoverage-legacy": "open ./coverage/legacy/lcov-report/index.html"
     },
     "activationEvents": [
-        "workspaceContains:sfdx-project.json"
+        "workspaceContains:sfdx-project.json",
+        "onLanguage:apex",
+        "onLanguage:soql",
+        "onLanguage:visualforce"
     ],
     "main": "./out/extension.js",
     "contributes": {
@@ -132,11 +135,6 @@
             {
                 "title": "General",
                 "properties": {
-                    "codeAnalyzer.enableV5": {
-                        "type": "boolean",
-                        "default": false,
-                        "description": "Use Code Analyzer v5 (Beta) instead of Code Analyzer v4."
-                    },
                     "codeAnalyzer.analyzeOnSave.enabled": {
                         "type": "boolean",
                         "default": false,
@@ -150,22 +148,32 @@
                     "codeAnalyzer.apexGuru.enabled": {
                         "type": "boolean",
                         "default": false,
-                        "description": "Discover critical problems and performance issues in your Apex code with ApexGuru, which analyzes your Apex files for you. This feature is in a closed pilot; contact your account representative to learn more."
+                        "description": "(Pilot) Discover critical problems and performance issues in your Apex code with ApexGuru, which analyzes your Apex files for you. This feature is in a closed pilot; contact your account representative to learn more."
+                    },
+                    "codeAnalyzer.Use v4 (Deprecated)": {
+                        "type": "boolean",
+                        "default": false,
+                        "markdownDescription": "Use Code Analyzer v4 (Deprecated) instead of Code Analyzer v5.\n\nWe no longer support Code Analyzer v4 and will soon remove this setting. We highly recommend that you use [Code Analyzer v5](https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/guide/code-analyzer.html) instead. Selecting this setting ignores the Code Analyzer v5 settings and uses the v4 settings instead.\n\nIf you have having trouble switching to v5, create an [issue](https://github.com/forcedotcom/sfdx-code-analyzer-vscode/issues)."
                     }
                 }
             },
             {
-                "title": "Code Analyzer v5 (Beta)",
+                "title": "Code Analyzer v5",
                 "properties": {
+                    "codeAnalyzer.configFile": {
+                        "type": "string",
+                        "default": "",
+                        "markdownDescription": "Path to a [Code Analyzer configuration file](https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/guide/config-custom.html) used to customize the engines and rules.\n\nCode Analyzer has an internal default configuration for its rule and engine properties. If you want to override these defaults, you can either add a 'code-analyzer.yml' or 'code-analyzer.yaml' file at the root of your project or explicitly specify your configuration file path with this setting.\n\nThis setting is equivalent to the `--config-file` flag of the CLI commands. See [configuration schema](https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/guide/config-toplevel.html)."
+                    },
                     "codeAnalyzer.ruleSelectors": {
                         "type": "string",
                         "default": "Recommended",
-                        "markdownDescription": "Specifies the default set of rules to use when executing Code Analyzer v5 (Beta). Specify the rules using their name, engine name, severity level, tag, or a combination. Use commas for unions (such as \"Security,Performance\") and colons for intersections (such as \"pmd:Security\" or \"eslint:3\")."
+                        "markdownDescription": "Selection of rules used to scan your code with Code Analyzer v5.\n\nSelect rules using their name, engine name, severity level, tag, or a combination. Use commas for unions (such as \"Security,Performance\") and colons for intersections (such as \"pmd:Security\" or \"eslint:3\").\n\nThis setting is equivalent to the `--rule-selector` flag of the CLI commands. See [examples](https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_code-analyzer_commands_unified.htm#cli_reference_code-analyzer_rules_unified)."
                     }
                 }
             },
             {
-                "title": "Code Analyzer v4",
+                "title": "Code Analyzer v4 (Deprecated)",
                 "properties": {
                     "codeAnalyzer.pMD.customConfigFile": {
                         "type": "string",
@@ -217,7 +225,7 @@
             "commandPalette": [
                 {
                     "command": "sfca.runOnActiveFile",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.runOnSelected",
@@ -229,11 +237,11 @@
                 },
                 {
                     "command": "sfca.runDfa",
-                    "when": "sfca.partialRunsEnabled && sfca.codeAnalyzerV4Enabled"
+                    "when": "sfca.extensionActivated && sfca.partialRunsEnabled && sfca.codeAnalyzerV4Enabled"
                 },
                 {
                     "command": "sfca.removeDiagnosticsOnActiveFile",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.removeDiagnosticsOnSelectedFile",
@@ -245,39 +253,39 @@
                 },
                 {
                     "command": "sfca.runApexGuruAnalysisOnCurrentFile",
-                    "when": "sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
+                    "when": "sfca.extensionActivated && sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
                 }
             ],
             "editor/context": [
                 {
                     "command": "sfca.runOnActiveFile",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.runDfaOnSelectedMethod",
-                    "when": "sfca.codeAnalyzerV4Enabled"
+                    "when": "sfca.extensionActivated && sfca.codeAnalyzerV4Enabled"
                 },
                 {
                     "command": "sfca.removeDiagnosticsOnActiveFile",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.runApexGuruAnalysisOnCurrentFile",
-                    "when": "sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
+                    "when": "sfca.extensionActivated && sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
                 }
             ],
             "explorer/context": [
                 {
                     "command": "sfca.runOnSelected",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.removeDiagnosticsOnSelectedFile",
-                    "when": "true"
+                    "when": "sfca.extensionActivated"
                 },
                 {
                     "command": "sfca.runApexGuruAnalysisOnSelectedFile",
-                    "when": "sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
+                    "when": "sfca.extensionActivated && sfca.apexGuruEnabled && resourceExtname =~ /\\.cls|\\.trigger|\\.apex/"
                 }
             ]
         },