--schema-qualify-objects functionality and some bugfixes#204
Open
ellmkay wants to merge 3 commits intofordfrog:developfrom
Open
--schema-qualify-objects functionality and some bugfixes#204ellmkay wants to merge 3 commits intofordfrog:developfrom
ellmkay wants to merge 3 commits intofordfrog:developfrom
Conversation
parser couldn't handle the way Postgres collates the column-list to the privilege: GRANT ALL(col1) ON TABLE table1 TO ellmkay; This is now fixed in the parser, and a test-case is added.
were diffing in a multi-schema setup.
instead of adding 'SET search_path' statements prior to diff output (the default behaviour), all statements will be schema-qualified. This commit touches quite a few files in the project, and also fixes a few privilege related bugs in passing. A thorough test case is also added.
ellmkay
changed the title
Collaborator
|
Might not need to be done in light of recent RLS changes? Either way, has conflicts and also needs another 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix column access privilege parsing.
Fix search-path output for privilege-only diffs in a multi-schema scenario.
Both fixes have test-cases.