fix: correct BrowserWindow icon path in src/main.js#27
Open
KernelChief wants to merge 1 commit intoforgexfoundation:mainfrom
Open
fix: correct BrowserWindow icon path in src/main.js#27KernelChief wants to merge 1 commit intoforgexfoundation:mainfrom
src/main.js#27KernelChief wants to merge 1 commit intoforgexfoundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the app icon path used when creating the BrowserWindow.
Change made
In
src/main.js, line 53 was updated from:to:
Why
main.jsis located insrc/, while the icon file is located in the top-levelassets/directory. The previous path resolved tosrc/assets/icon.png(non-existent). The new path correctly resolves toassets/icon.png.Scope
This PR is intentionally minimal and only includes the icon path fix (no unrelated Sonar/lint changes).
Verification