Skip to content

Conversation

@mattinannt
Copy link
Member

@mattinannt mattinannt commented May 22, 2025

Potential fix for https://github.com/formbricks/android/security/code-scanning/1

To fix the issue, we will add a permissions block to the workflow. Since the workflow primarily involves publishing to Maven Central, it does not appear to require write access to the repository contents. Therefore, we will set contents: read as the minimal permission. If additional permissions are required for specific operations, they can be added later.

The permissions block will be added at the workflow level (root) to apply to all jobs in the workflow.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by CodeRabbit

  • Chores
    • Updated workflow permissions for publishing to Maven Central to enhance security. No changes to functionality or user experience.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented May 22, 2025

Walkthrough

The GitHub Actions workflow configuration for publishing to Maven Central was updated to include a permissions section that grants read access to repository contents. No other modifications were made to the workflow's structure, triggers, jobs, or steps.

Changes

File(s) Change Summary
.github/workflows/publish-to-maven-central.yml Added a permissions section with contents: read to the workflow.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbccd85 and c94daa2.

📒 Files selected for processing (1)
  • .github/workflows/publish-to-maven-central.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: SonarCloud
🔇 Additional comments (1)
.github/workflows/publish-to-maven-central.yml (1)

4-5: Explicit minimal permissions added to satisfy security scanning
The new permissions block with contents: read implements the principle of least privilege and resolves the code scanning alert. This aligns with GitHub’s best practices for workflows.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mattinannt mattinannt changed the title Potential fix for code scanning alert no. 1: Workflow does not contain permissions fix: for code scanning alert no. 1: Workflow does not contain permissions May 22, 2025
@mattinannt mattinannt requested a review from pandeymangg May 22, 2025 10:33
@mattinannt mattinannt marked this pull request as ready for review May 22, 2025 10:33
@sonarqubecloud
Copy link

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mattinannt mattinannt added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 5016f9b May 27, 2025
7 checks passed
mattinannt added a commit that referenced this pull request Jun 2, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 5, 2025
…bile-SDK-Custom) (#26)

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 10, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 12, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 13, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 16, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 17, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

* add try catch cancel call api

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 27, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

* add try catch cancel call api

* fix(android): adjust WebView height manually on Android 10 when keyboard is visible

---------

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: Matti Nannt <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants