fix(hub): remove database URL from logs to prevent credential exposure #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database URL contains sensitive information (password) and should not be logged even at INFO level. Simplified the log message to just confirm the database connection succeeded.
The database URL contains sensitive information (password) and should not be logged even at INFO level. Simplified the log message to just confirm the database connection succeeded.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security Fix: Remove Database URL from Logs
Problem
The database connection log was printing the full PostgreSQL connection URL, which includes the database password. This is a security risk as sensitive credentials were being exposed in application logs.
Solution
Removed the database URL from the log output. The connection confirmation message is still logged, but without exposing the connection string containing credentials.
Changes
logger.Info("database connected")to only log the message without connection pool details or URLformbricks-rewritetoformbricks/hubto reflect the correct repository structureImpact