refactor(hub): update Go module path to match repository URL #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Change module from github.com/formbricks/formbricks-rewrite/apps/hub to github.com/formbricks/hub - Update all internal package imports across 30+ files to use the new module path - Update imports in cmd/hub/main.go and cmd/generate-openapi/main.go - Verified compilation and go mod tidy passes - CI workflows compatible with new module path (no hardcoded module references)
mattinannt
force-pushed
the
fix/update-go-module-path
branch
from
3719276 to
e37f63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Update Go Module Path to Match VCS Layout (Go Best Practice)
Problem
The Go module path should always match the VCS layout. Since
go.modlives inapps/hub/, the module path must include that to be fetchable and reusable by external projects.Solution
Updated to follow Go's recommended multi-module monorepo pattern:
go.modtogithub.com/formbricks/hub/apps/hubgithub.com/formbricks/hub/apps/hub/internal/...Why This Matters
go.modlocation)go get github.com/formbricks/hub/apps/hubgo.workfor local monorepo developmentFiles Changed
go.mod- Updated module togithub.com/formbricks/hub/apps/hubapps/hubin pathTesting
go build ./cmd/hubgo mod tidycompletes without errorsReferences