Conversation
mattinannt
approved these changes
Jan 24, 2026
Member
mattinannt
left a comment
There was a problem hiding this comment.
@xernobyl thank you for the PR :-) It looks good and I love the new checks that we now have. I'll also make them mandatory for every PR to pass once the PR is merged.
I made a few smaller updates including pinning all versions of the go tools used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands the CI workflow with comprehensive quality checks and adds git hooks for local development. It also improves the Makefile with better tool detection and separates unit tests from integration tests.
Changes
CI Workflow Enhancements
go.modandgo.sumare in syncmake fmt-check)make lint)govulncheck)make test-unit) - Fast, no database requiredmake tests) - Full database testsGit Hooks
.githooks/pre-commit):gofumptgolangci-lintmake install-hookstarget to install hooksmake dev-setupto automatically install hooksMakefile Improvements
test-unittarget - Runs unit tests only (fast)command -vinstead of hardcoded pathsfmtandfmt-check- Better error messages and tool detectionschemathesis- Removed operation exclusionTest Updates
API_KEYenvironment variableTesting
The CI workflow now runs:
All checks must pass for PRs to be merged.