chore: Convert field_type from VARCHAR to PostgreSQL ENUM#8
Merged
Conversation
mattinannt
approved these changes
Feb 2, 2026
Member
mattinannt
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
field_typecolumn from VARCHAR to a PostgreSQL ENUM type, and implements a type-safe string-based enum in Go to ensure only valid field types can be used.Changes
Database Schema
sql/001_initial_schema.sql: Updated to usefield_type_enuminstead of VARCHARGo Models (
internal/models/feedback_records.go)FieldTypestring-based enum type with constantsValidFieldTypesmap usingmap[FieldType]struct{}for efficient set membership checksIsValid()andParseFieldType()methodsUnmarshalJSON()for JSON validationFieldTypeinstead ofstring:FeedbackRecord.FieldTypeCreateFeedbackRecordRequest.FieldTypeListFeedbackRecordsFilters.FieldTypeValidation (
internal/api/validation/validation.go)validateFieldTypeto usemodels.ParseFieldType()andValidFieldTypesmap*FieldTypein query parametersOpenAPI Specification
field_typein response schemafield_typequery parameterBenefits
struct{}map values