Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request integrates SonarQube for code quality analysis, enhances test resource management, and refactors the mock service for improved modularity.
- Adds a GitHub Actions workflow and sonar-project.properties for SonarQube integration.
- Updates Package.swift to include test resource files.
- Modifies the mock service to use Bundle.module for improved resource loading.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sonar-project.properties | Introduces SonarQube configuration settings for sources, tests, and coverage. |
| Tests/FormbricksSDKTests/MockFormbricksService/MockFormbricksService.swift | Refactors mock service to use Bundle.module when loading JSON resources. |
| Package.swift | Updates test target to process resource files for tests. |
| .github/workflows/sonarqube.yml | Adds a workflow to run SonarQube scans with GitHub Actions. |
mattinannt
approved these changes
May 15, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces SonarQube integration for code quality and coverage analysis, adds support for resource files in tests, and refactors the mock service for improved modularity. Below are the most significant changes grouped by theme:
SonarQube Integration:
.github/workflows/sonarqube.yml) to run SonarQube scans, including steps for building the project, running tests, generating coverage reports, and uploading them to SonarCloud.sonar-project.propertiesto configure SonarQube for the project, specifying source and test locations, coverage report paths, exclusions, and encoding settings.Test Resource Management:
Package.swiftto include test resources (Mock/User.jsonandMock/Environment.json) in theFormbricksSDKTeststarget.Mock Service Refactoring:
Tests/FormbricksSDKTests/Mock/MockFormbricksService.swifttoTests/FormbricksSDKTests/MockFormbricksService/MockFormbricksService.swiftfor better organization.MockFormbricksServiceto useBundle.modulefor loading mock JSON files, aligning with Swift Package Manager conventions.