Closed
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces several enhancements and fixes to the Formbricks SDK, focusing on improving functionality, test coverage, and maintainability. The changes include adding a SonarQube workflow for code quality analysis, enabling support for pre-initialization SDK operations, introducing dependency injection for the
SurveyManager, and improving test coverage with mock data and updated test cases.New Features and Enhancements:
.github/workflows/sonarqube.yml) to integrate SonarQube for code quality analysis, including steps for building, testing, and uploading coverage reports.setLanguagemethod inFormbricks.swiftto allow it to be called before SDK initialization, improving flexibility.Codebase Improvements:
SurveyManagerto support dependency injection via aFormbricksServiceProtocol, making it easier to mock services in tests. [1] [2]FormbricksEnvironment.swiftby replacingURLmanipulation with string concatenation.Testing Enhancements:
Mock/User.json,Mock/Environment.json) to support unit tests. [1] [2]FormbricksSDKTests.swiftby adding setup and teardown methods, testing pre-initialization behavior, and validating asynchronous operations with expectations. [1] [2] [3]Debugging Additions:
SurveyManagerandAPIClientfor easier troubleshooting during development. [1] [2]