Skip to content

fix: bumps sonarscan action version #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattinannt merged 4 commits into from
Sep 23, 2025
Merged

fix: bumps sonarscan action version #29

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
720ae64
bumps sonarscan action version
pandeymangg Sep 23, 2025
63a272f
fixes the ios version for the io simulator
pandeymangg Sep 23, 2025
6280b9c
fix: failing test
pandeymangg Sep 23, 2025
1aa5189
fix: adds notification for environment refresh
pandeymangg Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/sonarqube.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
-scheme 'FormbricksSDK' \
-sdk iphonesimulator \
-config Debug \
-destination 'platform=iOS Simulator,name=iPhone SE (3rd generation),OS=18.2' \
-destination 'platform=iOS Simulator,name=iPhone SE (3rd generation),OS=18.4' \
-derivedDataPath build \
-enableCodeCoverage YES

Expand All @@ -39,7 +39,7 @@ jobs:

# Run SonarCloud scan, pointing at the Cobertura report
- name: SonarCloud Scan
uses: SonarSource/sonarqube-scan-action@v5.2.0
uses: SonarSource/sonarqube-scan-action@fd88b7d7ccbaefd23d8f36f73b59db7a3d246602 # v6.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions Tests/FormbricksSDKTests/FormbricksSDKTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,13 @@ final class FormbricksSDKTests: XCTestCase {
UserDefaults.standard.set(Data([0x00, 0x01]), forKey: "environmentResponseObjectKey")
XCTAssertNil(manager.environmentResponse)

// Timer-based refresh (use more generous timeouts)
// Timer-based refresh
manager.refreshEnvironmentAfter(timeout: 0.1)
let expectation = XCTestExpectation(description: "Timer fired")
DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
DispatchQueue.global().asyncAfter(deadline: .now() + 0.3) {
expectation.fulfill()
}
wait(for: [expectation], timeout: 1.0)
wait(for: [expectation], timeout: 2.0)

// getLanguageCode coverage
let survey = Survey(
Expand Down