Skip to content

Conversation

@pandeymangg
Copy link
Contributor

Fixes some additional sonarqube maintainability issues in the dashboard

@coderabbitai
Copy link

coderabbitai bot commented Sep 24, 2025

Walkthrough

Imports in config files were changed to Node.js namespace aliases: node:path (and node:url) in apps/playground/eslint.config.mjs and packages/js/vite.config.ts. The ESLint config still computes __filename via fileURLToPath(import.meta.url) and __dirname usage is unchanged. The Vite config’s plugins array was reformatted to a multi-line representation without changing options. In apps/playground/globals.css, single quotes were replaced with double quotes, NOSONAR comments were moved inline on @plugin and @custom-variant, one blank line inside @layer base was removed, and trailing newline/whitespace adjusted.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix: fixes some sonar issues" correctly indicates the PR's intent to address SonarQube maintainability issues in the repository and relates to the changes (import specifier updates and CSS NOSONAR adjustments); it is a short, single sentence. It is slightly redundant ("fix:" + "fixes") and could be more specific about the scope of changes.
Description Check ✅ Passed The description "Fixes some additional sonarqube maintainability issues in the dashboard" is directly related to the changes in the PR and states the intent; it is brief but acceptable under this lenient check.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9de4a8e and d1e2148.

📒 Files selected for processing (1)
  • apps/playground/globals.css (2 hunks)
🔇 Additional comments (2)
apps/playground/globals.css (2)

1-1: LGTM on quote normalization

Switching to double quotes on the import is fine and consistent with common CSS style.


23-23: LGTM

No behavior change; closing brace alignment remains correct after whitespace tweaks.

@sonarqubecloud
Copy link

@pandeymangg pandeymangg added this pull request to the merge queue Sep 25, 2025
Merged via the queue into main with commit 668c9d6 Sep 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants