Add code formatters for Telemetry #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bvngee
reviewed
Apr 4, 2025
| #!/bin/sh | ||
| set -e | ||
|
|
||
| HOOK_SOURCE="telemetry/hooks/pre-commit" |
There was a problem hiding this comment.
I might be blind but I think this is the wrong filepath? The other PR you made had the right one i think
|
all the frontend code is in telemetry-vis-software so the prettier stuff can be removed from this pr altogether :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of implementation of coding standards, I'd like to add code formatters to this repo for both embedded and frontend work. Embedded uses Google's .clang-format file, and frontend uses the basic .prettierrc file given by prettier on their site.