Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to harden Github actions and workflows against malicious actors.
It is an initial pass only, there are several items left for future PRs.
Most of the changes come from findings by either zizmor or actionlint
I have formatted the workflow files for consistency (yamlls), and fixed a typo in one of the job names as well as added a missing job name for the Docker image build.
The substantial changes in this PR (with links to the corresponding audit rules from the tools) are:
usestepsNote that this changes the default permissions in workflows to the empty set. I have tried to guess the necessary permissions for each job where applicable, but it is very possible I have missed something.
We might want to use https://github.com/GitHubSecurityLab/actions-permissions/tree/main to verify the minimal permissions for each job before this PR gets merged.