Add optional Hub label for tunnel naming#32
Merged
dmitryperets merged 2 commits intorelease/7.4from Nov 28, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default naming convention for the tunnels generated on the Spokes is:
For example, for a Dual-Hub topology we will generate tunnels like
H1_INETandH2_INET.To simplify operations, we introduce an option to set a more meaningful label for each Hub, using an optional
hub_nameparameter in thehubsstructure:If this option is defined, the naming convention will be:
In other words:
TRN_INET.Similarly, this optional name will be used for the Hub-to-Hub tunnels in a multi-regional deployment (e.g.
EAST_TRN_INET).