Skip to content

Support channel binding in init_ldap_session()#2120

Open
dadevel wants to merge 1 commit intofortra:masterfrom
dadevel:patch-1
Open

Support channel binding in init_ldap_session()#2120
dadevel wants to merge 1 commit intofortra:masterfrom
dadevel:patch-1

Conversation

@dadevel
Copy link
Copy Markdown
Contributor

@dadevel dadevel commented Feb 12, 2026

This PR uses cannatag/ldap3#1087 to enable LDAP Channel Binding in multiple example scripts.

image

#1657 was closed accidentally. This PR is the successor.

Use cannatag/ldap3#1087 to enable LDAP Channel Binding in multiple example scripts.
@Neustradamus
Copy link
Copy Markdown

Neustradamus commented Feb 12, 2026

@dadevel: Thanks for your new PR which replaces this initial from 2023-11-28 closed by error:

Linked to:

@anadrianmanrique
Copy link
Copy Markdown
Collaborator

@dadevel thank for your PR.
In the context of #2097 we decided to progressively move away from ldap3, and move towards improving our ldap implementation. As mentioned in #2097, the benefits of that is having channel binding and signing support for all ldap based examples. Because of that, we will not merge PRs based on ldap3 code. We appreciate your contributions.
Also as mentioned, we're in the process of migrating examples to impacket.ldap in a separate branch . I can add you as reviewer by the time the PR gets ready to be reviewed if you want.
Thanks again, and apologies for any inconvenience

@dadevel
Copy link
Copy Markdown
Contributor Author

dadevel commented Feb 19, 2026

@anadrianmanrique Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants