Fix TS_ALL_PROCESSES_INFO parsing for RpcWinStationGetAllProcesses#2155
Open
alexisbalbachan wants to merge 1 commit intofortra:masterfrom
Open
Fix TS_ALL_PROCESSES_INFO parsing for RpcWinStationGetAllProcesses#2155alexisbalbachan wants to merge 1 commit intofortra:masterfrom
alexisbalbachan wants to merge 1 commit intofortra:masterfrom
Conversation
anadrianmanrique
requested changes
Mar 27, 2026
| return self.fields['pTsProcessInfo'].fields['Data'] | ||
|
|
||
| def getSid(self): | ||
| rawSid = self.fields['pSid']['Data'] if self.fields['pSid'].fields['ReferentID'] else b'' |
Collaborator
There was a problem hiding this comment.
rawSid it's returned for those cases where it's populated by the target, as a UCHAR_ARRAY, which is not expected by code client, as they expect to be a buffer. change line 1380 for rawSid = b''.join( self.fields['pSid']['Data'] ) if self.fields['pSid'].fields['ReferentID'] else b''
| rawSid = self.fields['pSid']['Data'] if self.fields['pSid'].fields['ReferentID'] else b'' | ||
| if not rawSid: | ||
| return '' | ||
| return SID().known_sid(format_sid(rawSid)) |
Collaborator
There was a problem hiding this comment.
do not use ldap3 helpers, as we're moving away from ldap3 depdency
Collaborator
|
regarding getSid issue, on my tests, pSid has never been populated by the target. not clear to me when this condition changes. This code on the other hand is able to trigger the bug: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1816 by replacing the heuristic parsing of
RpcWinStationGetAllProcesseswith a proper NDR structure implementation based on the protocol spec. Since the response is now modeled according to the actualTS_ALL_PROCESSES_INFOlayout, the example code was also updated to use the corrected process and SID fields.