Intent specifications for all subroutines #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage ? 82.99%
=======================================
Files ? 67
Lines ? 2317
Branches ? 182
=======================================
Hits ? 1923
Misses ? 394
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zoziha
reviewed
Oct 1, 2025
There was a problem hiding this comment.
The incorrect intent identifiers have been captured very well. @loiseaujc, thank you for sharing.
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
zoziha
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple PR adding
intentspecifications to all the subroutines. This is a first step towardpure-ification of the code. I also ranfprettifyon all the files and started to follow some good practices provided by thefortitudelinter.Ping: @perazz, @zoziha