Fix -fPIC for C sources #1206
Open
Fix -fPIC for C sources #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use get_debug_compile_flags and get_release_compile_flags for pulling the default flags instead of hard-coding them in features_collection.f90.
A better solution would be to define getters for CFLAGS i.e. get_debug_compile_c_flags and get_release_compile_c_flags. Use them to pull the default flags for C sources.
perazz
reviewed
Nov 15, 2025
Member
perazz
left a comment
perazz
left a comment
There was a problem hiding this comment.
Thank you so much for this PR @MilanSkocic -
Please generalize default_variant instead:
- add character(*), optional, intent(in) :: c_flags, cxx_flags arguments
- set them if present
- customize the compiler/OS default variants for both debug and release by adding the PIC flag (may not be the same on all platforms)
Author
|
That's what I wanted to do by adding optional arguments. |
Imports not needed for now. They will be necessary if a solution by using functions defined in the module `fpm_compiler.F90` is decided.
All variants, except those for OS_WINDOWS, will accept the -fPIC flag for C/C++ sources. A more complete set of flags for C/C++ sources was added for the gcc compiler. For the other compilers, additional work might be needed to define the correct flags mathcing those passed for Fortran sources.
All variants, except those for OS_WINDOWS, will accept the -fPIC flag for C/C++ sources. A more complete set of flags for C/C++ sources was added for the gcc compiler. For the other compilers, additional work might be needed to define the correct flags mathcing those passed for Fortran sources.
The argument flags was made optional and 2 additional optional arguments were added i.e. c_flags and cxx_flags. The default values for featture%flags, feature%c_flags and feature%cxx_flags were set to an empty string. The latter are set if the respective optional arguments are defined. flags, c_flags and cxx_flags are set from the callers default_release_feature and default_debug_feature. This way there won't be backward compatibility as the flags were already defined in the callers. For now, the c_flags and cxx_flags are limited to the fPIC flag necessary for the shared libraries except for the variant with the gcc compiler where equivalent c_flags to flags were defined. More work is needed to complete the set of c_flags and cxx_flags for other variants.
Author
|
I have generalized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1205 highlighted that the
fPIC, necessary for shared libraries, was not passed for C sources either with profilereleaseordebug.For
CFLAGS, a hot fix was applied i.e. the flag is hard-coded 353ec23.Equivalent function of
fpm_compiler.F90/get_<debug/release>_compile_flagsshould be implemented for pulling default flags for C sources as it is the case for Fortran sources.The
FFLAGSare hard-coded both profiles (releaseanddebug) infeature_collection/default_<release/debug>_feature(). However, it might better to pull from default compile flags defined infpm_compiler.F90/get_<release/debug>_compile_flag(cb7d15c)