-
Notifications
You must be signed in to change notification settings - Fork 111
Draft: initial implementation of implicit_none #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -257,7 +257,7 @@ subroutine build_target(model,target,stat) | |
integer, intent(out) :: stat | ||
|
||
integer :: ilib, fh | ||
character(:), allocatable :: link_flags | ||
character(:), allocatable :: link_flags, implicit_flag | ||
|
||
if (.not.exists(dirname(target%output_file))) then | ||
call mkdir(dirname(target%output_file)) | ||
|
@@ -266,7 +266,12 @@ subroutine build_target(model,target,stat) | |
select case(target%target_type) | ||
|
||
case (FPM_TARGET_OBJECT) | ||
call run(model%fortran_compiler//" -c " // target%source%file_name // target%compile_flags & | ||
if (model%implicit_none) then | ||
implicit_flag = " -fimplicit-none" | ||
else | ||
implicit_flag = "" | ||
end if | ||
Comment on lines
+269
to
+273
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't seem like the right place to add this option. At this point we are not aware which compiler we are using anymore and cannot be sure that we are actually passing the correct flag. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, see the first TODO item. |
||
call run(model%fortran_compiler//" -c " // target%source%file_name // target%compile_flags // implicit_flag & | ||
// " -o " // target%output_file, echo=.true., exitstat=stat) | ||
|
||
case (FPM_TARGET_C_OBJECT) | ||
|
Uh oh!
There was an error while loading. Please reload this page.