Skip to content

Add validation for op argument in spmv routine for special matrices #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahmood-Sinan wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −0
Open

Add validation for op argument in spmv routine for special matrices #1087

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b25b6f
added error check for spmv operation argument
Mahmood-Sinan Jan 7, 2026
230df7e
changed error message
Mahmood-Sinan Jan 8, 2026
b46c6a8
accept 'H' as op in spmv and map to 'C' internally
Mahmood-Sinan Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/stdlib_specialmatrices_tridiagonal.fypp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ submodule (stdlib_specialmatrices) tridiagonal_matrices
${t1}$ :: alpha_, beta_
integer(ilp) :: n, nrhs, ldx, ldy
character(1) :: op_

type(linalg_state_type) :: err0
#:if t1.startswith('real')
logical :: is_alpha_special, is_beta_special
#:endif
Expand All @@ -171,10 +173,19 @@ submodule (stdlib_specialmatrices) tridiagonal_matrices
${t1}$, pointer :: xmat(:, :), ymat(:, :)
#:endif

if(present(op)) then
if(.not.(op == "N" .or. op == "T" .or. op == "C" .or. op == "H")) then
err0 = linalg_state_type(this, LINALG_VALUE_ERROR, "Invalid matrix operation; expected 'N', 'T', 'C' or 'H'.")
call linalg_error_handling(err0)
end if
end if

! Deal with optional arguments.
alpha_ = 1.0_${k1}$ ; if (present(alpha)) alpha_ = alpha
beta_ = 0.0_${k1}$ ; if (present(beta)) beta_ = beta
op_ = "N" ; if (present(op)) op_ = op
if (op_ == "H") op_ = "C"

#:if t1.startswith('real')
is_alpha_special = (alpha_ == 1.0_${k1}$ .or. alpha_ == 0.0_${k1}$ .or. alpha_ == -1.0_${k1}$)
is_beta_special = (beta_ == 1.0_${k1}$ .or. beta_ == 0.0_${k1}$ .or. beta_ == -1.0_${k1}$)
Expand Down
Loading