Skip to content

Fix: logspace generate wrong result for integer arguments #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MadhurKumar004 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −8
Open

Fix: logspace generate wrong result for integer arguments #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/math/stdlib_math.fypp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ module stdlib_math
integer, intent(in) :: end
integer, intent(in) :: n
integer, intent(in) :: base
! integer endpoints + integer base = integer result
integer :: res(max(n, 0))
! integer endpoints + integer base = real(dp) result
real(dp) :: res(max(n, 0))
end function ${RName}$


Expand Down
18 changes: 12 additions & 6 deletions src/math/stdlib_math_logspace.fypp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,24 +69,30 @@ contains
#:for k1 in REAL_KINDS
#:set RName = rname("logspace", 1, "integer(int32)", "int32", "n_r" + str(k1) + "base")
module procedure ${RName}$
integer :: exponents(max(n, 0))
exponents = linspace(start, end, n)
real(${k1}$) :: exponents(max(n, 0))
exponents = linspace(real(start, kind=${k1}$), real(end, kind=${k1}$), n)
res = base ** exponents
if (n > 1) res(1) = base ** start
if (n > 0) res(n) = base ** end
end procedure

#:set RName = rname("logspace", 1, "integer(int32)", "int32", "n_c" + str(k1) + "base")
module procedure ${RName}$
integer :: exponents(max(n, 0))
exponents = linspace(start, end, n)
complex(${k1}$) :: exponents(max(n, 0))
exponents = cmplx(linspace(real(start, kind=${k1}$), real(end, kind=${k1}$), n), 0.0_${k1}$)
res = base ** exponents
if (n > 1) res(1) = base ** start
if (n > 0) res(n) = base ** end
end procedure
#:endfor

#:set RName = rname("logspace", 1, "integer(int32)", "int32", "n_ibase")
module procedure ${RName}$
integer :: exponents(max(n, 0))
exponents = linspace(start, end, n)
real(dp) :: exponents(max(n, 0))
exponents = linspace(real(start, kind=dp), real(end, kind=dp), n)
res = base ** exponents
if (n > 1) res(1) = base ** real(start, kind=dp)
if (n > 0) res(n) = base ** real(end, kind=dp)
end procedure


Expand Down
Loading