ci: add s390x big-endian workflow for hash function tests#1132
Closed
ijatinydv wants to merge 2 commits intofortran-lang:masterfrom
Closed
ci: add s390x big-endian workflow for hash function tests#1132ijatinydv wants to merge 2 commits intofortran-lang:masterfrom
ijatinydv wants to merge 2 commits intofortran-lang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
+ Coverage 68.02% 68.05% +0.03%
==========================================
Files 402 402
Lines 12839 12839
Branches 1383 1383
==========================================
+ Hits 8734 8738 +4
+ Misses 4105 4101 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jvdp1,
Following up on our discussion in #1130 , this PR adds a dedicated CI job to catch any future Big-Endian regressions.
It uses
uraimo/run-on-arch-actionto emulate ans390x(IBM Z) environment using QEMU. Since QEMU emulation is notoriously slow, I've heavily optimized the workflow so it doesn't bottleneck the rest of the project's CI or burn through Actions minutes:stdlib, it usescmake --build build --target test_hash_functions. This only compiles the hash modules and their direct dependencies, completely skipping heavy modules likelinalgorstats.src/hash/,test/hash_functions/, or the workflow file itself is modified. Otherwise, it just runs on merges tomaster.apt-getdependency layer, and adds--no-tests=errortoctestto ensure the CI forcefully fails if the test target gets renamed in the future.I've tested this on my fork and it successfully catches the endianness issues we just fixed. Let me know if you'd like to tweak the scope or triggers at all!