enhance: strip user session information before forwarding#19
Open
LaurenceJJones wants to merge 3 commits intofosrl:mainfrom
Open
enhance: strip user session information before forwarding#19LaurenceJJones wants to merge 3 commits intofosrl:mainfrom
LaurenceJJones wants to merge 3 commits intofosrl:mainfrom
Conversation
- Add stripSessionCookies() to remove session cookies from Cookie header - Add stripSessionParam() to remove session exchange query parameter from URL - Call both before forwarding request to backend on valid sessions - Backend now only receives user identity via Remote-* headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
This PR introduces upstream request sanitization so Badger can consume session/auth data for validation while preventing those sensitive values from being forwarded to backend services.
Why
Badger should validate session material but not forward that sensitive session/auth context to downstream apps.
This change ensures:
Least-privilege forwarding:
Downstream receive identity context, not raw session secrets.
Reduced leakage risk:
Session tokens are removed from URL query, headers, and cookies before proxying (and logs/observability systems downstream are less likely to capture secrets).
Consistent sanitization:
Stripping is applied in one place for all supported transport paths (query params, headers, cookies).
Traefik plugin compatibility:
Implementation avoids APIs unavailable in Yaegi, preventing plugin load failures while keeping sanitization behavior intact.
What changed
Behavior notes
How to test?
Personally I setup a whoami container behind pangolin SSO and used an invite link, use a preauthenticated browser to access the resource, what was echoed to the page was all sensitive information being removed before forwarded to backend service but headers for user auth like remote-user are preserved.