-
-
Notifications
You must be signed in to change notification settings - Fork 482
feat: login page customization #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
miloschwartz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thanks Fred! A few small tweaks but hopefully nothing hard -- mostly around how the feature is presented when in an unlicensed or unsubscribed state. I included some screenshots with notes, so hopefully that helps.
| redirect(`/${orgId}`); | ||
| } | ||
|
|
||
| let subscriptionStatus: GetOrgTierResponse | null = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should move this to a helper function for server components to reuse? If it's tricky to do, don't worry about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that yes
|
Hi @Fredkiss3 |
@Lokowitz thanks for the heads up |
|
@Lokowitz I merged the Here is an example of the changes it added: # server/blueprint/types.ts
export const SiteSchema = z.object({
name: z.string().min(1).max(100),
- "docker-socket-enabled": z.boolean().optional().default(true)
+ "docker-socket-enabled": z.boolean().optional().prefault(true)
});
export const TargetHealthCheckSchema = z.object({
hostname: z.string(),
port: z.int().min(1).max(65535),
- enabled: z.boolean().optional().default(true),
+ enabled: z.boolean().optional().prefault(true),
path: z.string().optional(),
scheme: z.string().optional(),
- mode: z.string().default("http"),
- interval: z.int().default(30),
- "unhealthy-interval": z.int().default(30),
+ mode: z.string().prefault("http"),
+ interval: z.int().prefault(30),
+ "unhealthy-interval": z.int().prefault(30),
unhealthyInterval: z.int().optional(), // deprecated alias
- timeout: z.int().default(5),
- headers: z.array(z.object({ name: z.string(), value: z.string() })).nullable().optional().default(null),
- "follow-redirects": z.boolean().default(true),
+ timeout: z.int().prefault(5),
+ headers: z.array(z.object({ name: z.string(), value: z.string() })).nullable().optional().prefault(null),
+ "follow-redirects": z.boolean().prefault(true),
followRedirects: z.boolean().optional(), // deprecated alias
- method: z.string().default("GET"),
+ method: z.string().prefault("GET"),
status: z.int().optional()
});
### and way more...
|
|
Ah yeah, sorry for not pointing at this. |
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Main changes:
Other changes:
process.exit(0)line to the migration script because otherwise the migration script would just hang even though it has already finished running https://github.com/Fredkiss3/pangolin/blob/7a31292ec7192efae9b1be30fa5113153150debe/server/db/pg/migrate.ts#L13-L14build.tsfile like this:buildeverywhere and is validated by TypeScript.exactto theHorizontalTabscomponent to match paths exactlyScreenshots