feat(resources): add redirect domain management in settings#2493
Open
LaurenceJJones wants to merge 2 commits intofosrl:devfrom
Open
feat(resources): add redirect domain management in settings#2493LaurenceJJones wants to merge 2 commits intofosrl:devfrom
LaurenceJJones wants to merge 2 commits intofosrl:devfrom
Conversation
- add redirect domains section in resource settings - add 'Add Redirect' flow using DomainPicker - validate redirect domains to prevent primary-domain and duplicate entries - normalize redirect domains before save (ASCII/lowercase) - support removing redirect domains from the configured list - add translation-key fallbacks for new redirect copy
Member
Author
|
Thinking more about the feature, it may be better design decision to think of these as "HTTPS" resources which could either point towards another resource so for example in the "target" section instead of a site + url it could just be an extension then there is more power in the resources section as nothing is hidden under the edit tab of a resource? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
I’m not sure of the best migration approach here, since this feature requires adding a new column to the resources table so its bundle inside of the PR, but maintainers may want to change it to a minor version since its a new feature?
however, there may be another option which we create a dedicate table for this? 🤷🏻
How to test?
When editing a resource, under the general tab you now have "Redirect" options which allow you to set subdomains or another domain (that added in the system) to redirect to the currently edited resource. This is useful as users may host a website on the base domain and requests to
www.should be redirected to the base domain on a permanent redirect (or the reverse depending on the user preference).Before scaffolding this feature the only option would be to create another resource that take the subdomain and points to the same target, however, that is not scalable and creates duplicate records.
Open to comments/feedback on the PR as direction may have to change or may prompt new ideas on how to achieve this.