Make the frnd function round according to the C 'round' spec #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this is correct as I don't have access to the ARC V3 specification, but if GCC is correct and QEMU is wrong, then the fdrnd (and fsrnd) functions are supposed to round with ties rounding away from zero, just like the C round and roundf functions. Signed-off-by: Keith Packard <[email protected]>
Contributor
Author
|
Reviewing the spec, this patch appears to be incorrect. Testing with the current bits shows no errors either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is correct as I don't have access to the ARC V3 specification, but if GCC is correct and QEMU is wrong, then the fdrnd (and fsrnd) functions are supposed to round with ties rounding away from zero, just like the C round and roundf functions.