docs: add misa q bit #1
Merged
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new Q (quad precision float) extension control and exposes its CSR bit in misa.
- Introduces a
MUTABLE_MISA_Qparameter to enable or disable mutability of themisa.Qbit. - Registers the
Qfield inarch/csr/misa.yamlwith conditional read/write behavior based on the new parameter. - Implements field type, reset value, write legality, and constraint checks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| arch/ext/Q.yaml | Defines MUTABLE_MISA_Q parameter under extension schema |
| arch/csr/misa.yaml | Adds Q CSR field with RW/RO logic, reset value, and legality checks |
Comments suppressed due to low confidence (1)
arch/csr/misa.yaml:172
- No tests were added or updated to verify the new
MUTABLE_MISA_Qbehavior and theQCSR field; consider adding unit tests covering both mutable and immutable scenarios.
Q:
AFOliveira
requested changes
May 22, 2025
Collaborator
AFOliveira
left a comment
AFOliveira
left a comment
There was a problem hiding this comment.
There may be changes needed in F and D, but let's change only the comment I made and wait for upstream feedback
arch/csr/misa.yaml
Outdated
| [when,"MUTABLE_MISA_Q == true"] | ||
| -- | ||
| Indicates support for the `Q` (quad precision float) extension. |
Collaborator
There was a problem hiding this comment.
Let's switch this to " Writing 0 to this field will cause all quad-precision floating point instructions to raise an IllegalInstruction exception. "
AFOliveira
approved these changes
May 22, 2025
Collaborator
AFOliveira
left a comment
AFOliveira
left a comment
There was a problem hiding this comment.
Maybe F and D will need updates but let's ask upstream folks opinion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.