arcv: Remove hardcoded ABI and ARCH flags. #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the hardcoded `-mabi=ilp32` and `-march=rv32im_zba_zbb_zbs_zca_zcb_zcmp_zicsr` options from the semihost compiler flags, the compiler will now use its default ABI and architecture settings unless specified elsewhere. This resolves the problem where these hardcoded values were overriding the specific ABI and architecture options required by certain tests. Signed-off-by: Luis Silva <[email protected]>
luismgsilva
force-pushed
the
luis/nsim-wrapper
branch
from
89a8d8b to
fcece99
Compare
Modified the nSIM setup logic to call setup_sim riscv when targeting ARCV. It returns a simulator named with the target alias and a "-run" suffix (for example, riscv64-unknown-elf-run), which can serve as a wrapper for the simulator. For non-ARCv targets, retain the previous behavior of setting the sim board info directly. Signed-off-by: Luis Silva <[email protected]>
luismgsilva
force-pushed
the
luis/nsim-wrapper
branch
from
fcece99 to
ed63f2c
Compare
yaroslavsadin
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the hardcoded
-mabi=ilp32and-march=rv32im_zba_zbb_zbs_zca_zcb_zcmp_zicsroptions from the semihostcompiler flags, the compiler will now use its default ABI and
architecture settings unless specified elsewhere. This resolves the
problem where these hardcoded values were overriding the specific ABI
and architecture options required by certain tests.
Modified the nSIM setup logic to call setup_sim riscv when targeting
ARCV. It returns a simulator named with the target alias and a "-run"
suffix (for example, riscv64-unknown-elf-run), which can serve as a
wrapper for the simulator.
For non-ARCv targets, retain the previous behavior of setting the sim
board info directly.