Skip to content

Conversation

@Aman071106
Copy link
Contributor

PR Description

This PR adds a clarification warning to the documentation regarding the temporary fix for removing .toJS() from printing_web.dart in the printing package. Recent Dart versions no longer require .toJS() for converting Dart strings to JavaScript strings, as reflected in the upstream change proposed in PR #1739.

Because the temporary workaround involves modifying files inside the user's local .pub-cache, this update adds a clear warning block explaining that such changes are not persistent and will be overwritten when:

  • running flutter pub get
  • clearing the pub cache
  • upgrading packages
  • setting up the project on a different machine

This improves documentation clarity and prevents confusion for users applying local patches.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • Yes
  • No - documentation-only update, tests not required.

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

Copy link
Member

@animator animator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@animator animator merged commit 3140181 into foss42:main Jan 16, 2026
@Aman071106 Aman071106 deleted the docs/web-build-warning branch January 16, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants