Skip to content

Switch to TypeScript#396

Open
rhbvkleef wants to merge 1 commit intofossamagna:masterfrom
rhbvkleef:master
Open

Switch to TypeScript#396
rhbvkleef wants to merge 1 commit intofossamagna:masterfrom
rhbvkleef:master

Conversation

@rhbvkleef
Copy link
Copy Markdown

No description provided.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 94.444% when pulling 6eab940 on rhbvkleef:master into d323a0b on fossamagna:master.

@rhbvkleef
Copy link
Copy Markdown
Author

How should I deal with the decreased coverage? The coverage did not effectively change. Only the if-statement checking compiler.hooks has one uncovered branch, just like in the upstream version.

@fossamagna
Copy link
Copy Markdown
Owner

@rhbvkleef
Thank you for your contribution.
Could you to fix belowing to:

  • Follow to master branch. (fix conflict)
  • Use ESLint + ESLint TypeScript Plugin instead of TSLint, because of TSLint is deprecated.

And, I think that no required to deal with the decreased coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants