Conversation
Flake lock file updates:
• Updated input 'flake-compat':
'github:edolstra/flake-compat/9100a0f413b0c601e0533d1d94ffd501ce2e7885' (2025-05-12)
→ 'github:edolstra/flake-compat/f387cd2afec9419c8ee37694406ca490c3f34ee5' (2025-10-27)
• Updated input 'phps':
'github:fossar/nix-phps/b325c114bef951cc334d1883fe6c17b286b59728' (2025-09-27)
→ 'github:fossar/nix-phps/d2807871f18ab2150b1e46b7ee126fe0bf200d4c' (2025-10-19)
• Updated input 'phps/nixpkgs':
'github:NixOS/nixpkgs/12bd230118a1901a4a5d393f9f56b6ad7e571d01' (2025-09-19)
→ 'github:NixOS/nixpkgs/3cbe716e2346710d6e1f7c559363d14e11c32a43' (2025-10-16)
Changelogs summary: - friendsofphp/php-cs-fixer updated from v3.88.2 to v3.89.1 minor See changes: PHP-CS-Fixer/PHP-CS-Fixer@v3.88.2...v3.89.1 Release notes: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.89.1 - phpstan/phpstan updated from 2.1.30 to 2.1.31 patch - vstelmakh/url-highlight updated from v3.1.2 to v3.1.3 patch See changes: vstelmakh/url-highlight@v3.1.2...v3.1.3 Release notes: https://github.com/vstelmakh/url-highlight/releases/tag/v3.1.3
- @eslint/js: 9.36.0 → 9.38.0 - core-js: 3.45.1 → 3.46.0 https://github.com/zloirock/core-js/releases/tag/v3.46.0 - dexie: 4.2.0 → 4.2.1 https://github.com/dexie/Dexie.js/releases/tag/v4.2.1 - eslint: 9.36.0 → 9.38.0 https://github.com/eslint/eslint/releases/tag/v9.38.0 https://github.com/eslint/eslint/releases/tag/v9.37.0 - focus-trap: 7.6.5 → 7.6.6 https://github.com/focus-trap/focus-trap/releases/tag/v7.6.6 - ramda: 0.31.3 → 0.32.0 ramda/ramda@v0.31.3...v0.32.0 - react-router: 7.9.3 → 7.9.4 https://github.com/remix-run/react-router/releases/tag/react-router%407.9.4 - rooks: 7.14.1 → 9.3.0 imbhargav5/rooks@rooks@7.14.1...rooks@8.0.0 https://github.com/imbhargav5/rooks/releases/tag/rooks%409.0.0 - stylelint: 16.24.0 → 16.25.0 https://github.com/stylelint/stylelint/releases/tag/16.25.0
This will be reported after the upcoming `eslint-plugin-react-hooks` bump: > Error: Calling setState synchronously within an effect can trigger cascading renders > > Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following: > * Update external systems with the latest state from React. > * Subscribe for updates from some external system, calling setState in a callback function when external state changes. > > Calling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect).
Avoid calling `setImagesLoaded` in `useEffect` to fix `react-hooks/set-state-in-effect` eslint rule. This will start to be an issue with the upcoming bump of `eslint-plugin-react-hooks`. Though the lint will complain about the same issue with `setFullScreenTrap`.
One more instance of the lint. I do not like `usingFocusTrap` not being coupled to the setting but not sure how to refactor it otherwise.
This will be reported after the upcoming `eslint-plugin-react-hooks` bump: > Compilation Skipped: Existing memoization could not be preserved > > React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `setEditedSource`, but the source dependencies were [source]. Inferred different dependency than source.
✅ Deploy Preview for selfoss canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.