Conversation
✅ Deploy Preview for selfoss canceled.
|
`RequestInit` and `HeadersInit` contain more fields that we might want.
Allows us to slightly simplify the `MessageFormat` code, while making the translations clearer. We already assume that in types. We already started with it in 6d268e3 but due to insufficient typing, we missed a few spots.
We were already doing that, just did not notice the wrong type annotation previously.
- Accept numbers for param values. - Add type annotations. - Use strict equality.
Stops TypeScript compiler complaining with `noImplicitAny` and ensures that we cannot use incorrect message key.
No need to repeat the checks on every call of `_`.
This was the last straggler.
Ensures that compiler knows what we intend.
Reduces the number of errors reported by TypeScript compiler in strict mode from 398 to 294.
jtojnar
force-pushed
the
react-improvements
branch
from
5400540 to
7564df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce globals, fix errors and enable
noImplicitAnyTypeScript option.Follow-up to #1543