-
Notifications
You must be signed in to change notification settings - Fork 28
Revert latest change pointing to some closed source software #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I would like to point to the company name. Its FOSS-ASIA, not closed-source-binary-ASIA ;) So please do not point to some closed source software when there is already the open source software linked that is working also on some closed source platform named Windows (wchisp-v0.3.0-win-x64.zip) . I removed the link to closed source software and added to description, that the open source tool wchisp work on Unix and Windows. https://github.com/ch32-rs/wchisp/releases/tag/v0.3.0
Reviewer's Guide by SourceryThis pull request removes the instructions for installing and using the closed-source No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @froscon2024 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Thanks for keeping the documentation focused on open-source tools.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I tried Zadig yesterday and found it really hard to install WinUSB because the ISP mode (bootloader) of the chip will last only 10 seconds, I have to do it really fast. It also happened to people using Windows at the event, that's why I told them to use WCHISPStudio. Perhaps we should have some way to install the driver automatically instead of using Zadig. FWIW: I have never touched Windows for years. It's frying my laptop. |
I just tried. Zadig is the best option out there =] |
If you really want to add the ability for the people to use closed source driver instead of the open source one on windows, then also this tool could be used: https://github.com/ch32-rs/wlink To hardly simplify: The currently used wchisp can also flash for example 8bit chips. But the CH58* used on the badge is more modern one with 32bit. That is why you can also use on linux and windows wlink software instead of wchisp software. For windows the difference would be that the people could use opensource and also their closed source driver. On Linux there would be no change in the flash functionality. The bad thing: You would loose the chance to push the people into using open source drivers on their closed source windows systems. I see it as a benefit having to push windows users in installing open source things on their systems. Merging this PR or asking me to write a different one that instead points everyone to use wlink to flash the badge on windows and linux would be both better then now. Then currently there is advertisement on the main page that push people into closed source software instead. @kienvo , you have used wlink with the additional external programmer to debug the badge here: #79 (comment) |
To use
So, enabling the debug port is still a problem on Windows anyway.
No, that is impossible.
I'm ok with this but not sure @mariobehling @Jhalakupadhyay what do you think? This upgrading fw has been a headache subject since we started this project. I've been working on these #37 and #38 issues and found this interesting MCUBoot and its client tools that could solve this problem if one own a badge that has the foss fw installed. |
I would like to point to the company name. Its FOSS-ASIA, not closed-source-binary-ASIA ;) So please do not point to some closed source software when there is already the open source software linked that is working also on some closed source platform named Windows (wchisp-v0.3.0-win-x64.zip) . I removed the link to closed source software and added to description, that the open source tool wchisp work on Unix and Windows. https://github.com/ch32-rs/wchisp/releases/tag/v0.3.0
Summary by Sourcery
Remove instructions for installing and using wchisp studio, a closed-source tool for flashing the badge firmware on Windows. Update the installation instructions to indicate that the open source wchisp tool works on both Unix and Windows.