Skip to content

Dropdown arrows visibility issue resolved #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Dropdown arrows visibility issue resolved #681

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f32c74
resolved color of dropdown arrow
satvikchachra Mar 2, 2020
a7416b9
changed color of dropdown arrows
satvikchachra Mar 8, 2020
dc7604f
resolved dropdown arrow issue using css breakpoints
satvikchachra Mar 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/theme-lava.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ nav .container {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
content: "\e688";
color: #fff;
color: #000000;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks weird on desktop, please use css breakpoints

@media screen and (min-width: 480px)
{
color : black;
}

font-size: 24px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have just removed the color property but the default color remains the same i.e.white so No change in UI

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mohitm15 and @Chaitanyassr for reviewing my pull request! :)
According to my understanding, the pull request made resolves the issue raised #672

I have attached screenshots and highlighted with a red rectangle, to show reflected changes.

Before
Screenshot (94)

After
Screenshot (103)

I wanted to ask instead of deleting the color property, should I set it to black and update my pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the color accordingly for that particular icon or class instead of deleting it

position: absolute;
top: -6px;
Expand Down