Skip to content

fix: Input of large values in setting #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: Input of large values in setting #602

wants to merge 2 commits into from

Conversation

dheerajkotwani
Copy link
Member

Fixes #601 App Crash on Entering Large Values in Setting

Changes:
Make the changes for the parse value

Screenshot/s for the changes:
neuro_solve_setting_crash

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@auto-label auto-label bot added the fix Solution to a bug or an issue label Jan 24, 2020
jddeep
jddeep suggested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@jddeep jddeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, just put a limit of 115 in each.

@dheerajkotwani
Copy link
Member Author

okay @jddeep I will change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

1 more reviewer

@jddeep jddeep jddeep requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Solution to a bug or an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: App crash on entering large value for Bins
2 participants
@dheerajkotwani @jddeep