Searching and Sorting Fix along with name to root folder #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions. Fixed Image Delete Issue , TrashBin Issue and More Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions. Update build.gradle Origin NullFix and Search Fix Images stored in Root directory or /sdcard now won't show or store null value as name. As a result on search and sorting , there would be no crash or termination since we are giving a name to the folder incase of that image is stored in /sdcard. Done with gradlew SpotlessApply
rob729
reviewed
Nov 20, 2019
rob729
left a comment
rob729
left a comment
There was a problem hiding this comment.
@satyajiit Squash these commits into a single commit
Contributor
|
@satyajiit please do the changes |
codedsun
suggested changes
Jan 7, 2020
Contributor
codedsun
left a comment
codedsun
left a comment
There was a problem hiding this comment.
@satyajiit - Please do the changes
iamareebjamal
approved these changes
Apr 10, 2020
Member
|
@satyajiit Please resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2926
Changes: Images stored in Root directory or /sdcard now won't show or store null value as name.
As a result doing search and sorting ,
there would be no crash or termination since we are giving a name to the folder in case of that image is stored in "/sdcard".
Screenshots of the change:
Before
After
This fixed the search issue which was also causing crash on sorting since we had a null value.