Skip to content

changed return type of onDown in RecyclerItemClickListner to false as returning true was blocking the recyclerview scroll event - to fix #3051 #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

changed return type of onDown in RecyclerItemClickListner to false as returning true was blocking the recyclerview scroll event - to fix #3051 #3142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/src/main/java/org/fossasia/phimpme/base/RecyclerItemClickListner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,8 @@ public void onLongPress(MotionEvent event) {

@Override
public boolean onDown(MotionEvent event) {
// Best practice to always return true here.
// http://developer.android.com/training/gestures/detector.html#detect
return true;
// returning true here will stop scroll event in recyclerview, return false instead
return false;
}
}
}