Skip to content

Conversation

@ethanleelge
Copy link
Contributor

Description

  1. If there is only one notice file, move it directly to the output folder.
    1-1. Add the following message to the log:
    Notice file to upload FOSSLight Hub: {output_path}/notice_to_fosslight_hub_{datetime}.{extension}

  2. If there are multiple notice files, compress them into a ZIP file and move it to the output folder.
    2-1. Add the following message to the log:
    Notice file to upload FOSSLight Hub: {output_path}/notice_to_fosslight_hub_{datetime}.zip

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@ethanleelge ethanleelge added the chore [PR/Issue] Refactoring, maintenance the code label Feb 19, 2025
@ethanleelge ethanleelge self-assigned this Feb 19, 2025
@soimkim
Copy link
Contributor

soimkim commented Feb 23, 2025

@ethanleelge , 수정된 코드에서는 notice 파일들을 압축하는 부분이 보이지 않습니다. import만 한 것으로 보입니다.
확인 부탁드립니다.

@ethanleelge
Copy link
Contributor Author

@soimkim 앗 제가 커밋을 잘못했던것 같습니다. 다시 한번 확인부탁드리겠습니다.

@soimkim
Copy link
Contributor

soimkim commented Feb 24, 2025

@ethanleelge , #38 로 추가 커밋 확인 부탁드립니다.

  1. print 대신 logger를 이용해주십시오.
  2. notice 파일 관련 작업을 하는 함수로 notice 압축 함수 호출 부분을 이동했습니다. (불필요하게 split을 다시하는 부분 제거, parameter 불필요한 부분 제거)
  3. line 맨 뒤에 불필요하게 추가되는 space 제거 부탁드립니다.

@soimkim soimkim closed this Feb 24, 2025
@soimkim soimkim deleted the compress_notice_files branch February 24, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants